Skip to content

[Backport release-24.11] qt6.qtdeclarative: add sigtool on Darwin#402215

Merged
vcunat merged 1 commit intoNixOS:release-24.11from
vcunat:p/qtdeclarative-darwin
Apr 27, 2025
Merged

[Backport release-24.11] qt6.qtdeclarative: add sigtool on Darwin#402215
vcunat merged 1 commit intoNixOS:release-24.11from
vcunat:p/qtdeclarative-darwin

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Apr 27, 2025

Needed since 6.9

(cherry picked from commit 5ee4400)
See #398849 (comment)

Things done

  • Built on platform(s)
    • no rebuild except on .isDarwin
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900 @vcunat
qt6.qtdeclarative: add sigtool on Darwin
8ad8b9d 
Needed since 6.9

(cherry picked from commit 5ee4400)
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Apr 27, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 27, 2025
@vcunat vcunat merged commit 8ad8b9d into NixOS:release-24.11 Apr 27, 2025
18 of 22 checks passed
@vcunat vcunat deleted the p/qtdeclarative-darwin branch April 27, 2025 06:10
@vcunat
Copy link
Member Author

vcunat commented Apr 27, 2025

I also checked nixfmt locally this time, to be sure.

@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 27, 2025
@nixos-discourse
Copy link

nixos-discourse commented Apr 27, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/macos-nixpkgs-24-11-qtdeclarative-6-8-3-result-in-bin-sh-codesign-command-not-found/63487/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@K900 K900 Awaiting requested review from K900

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vcunat @nixos-discourse @K900